JuliaLang / Compat.jl

Compatibility across Julia versions
Other
148 stars 117 forks source link

Remove unnecessary imports and re-definitions #645

Closed martinholters closed 5 years ago

martinholters commented 5 years ago

No need to explicitly pull in stuff exported from Base.

This was prompted when stumbling over https://github.com/JuliaLang/Compat.jl/blob/ce5d74bbd4b1eced53892a6d6ac6857ce1af53e8/src/Compat.jl#L161 and realizing this needs no deprecation at all; even when removing it, Compat.Iterators will be available as it is exported from Base. We have a couple of similar unnecessary imports and redefinitions (const foo = Base.foo) behind version conditionals which might prompt the same question---does this need a deprecation?---in the future when bumping the minimum required version. So I just thought I go ahead and answer that.