search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
145 stars 117 forks source link

Add uuid5 #685

Closed tkf closed 4 years ago

tkf commented 4 years ago

This PR adds uuid5 from https://github.com/JuliaLang/julia/pull/28761

martinholters commented 4 years ago

This makes Compat,namespace_dns, Compat,namespace_url, Compat,namespace_oid, and Compat,namespace_x500 available but doesn't mention them in the README. Providing functionality but not telling anyone seems inconsistent to me. What's the reason for this?

tkf commented 4 years ago

Thanks for catching it. It was an overlook.

martinholters commented 4 years ago

Hmm, https://github.com/JuliaLang/julia/pull/28761 neither exports nor documents those constants. Are they actually part of the API and guaranteed to stay for 1.x? Otherwise I'd prefer not to have a Compat for them. How much are these needed anyway?

tkf commented 4 years ago

I removed namespace_(dns|oid|url|x500) from src/Compat.jl. I suppose whoever wants them has to first document them in the UUIDs stdlib as stable API.

martinholters commented 4 years ago

Thanks. Better to be conservative here than to provide functionality that could happen to be removed from Julia...

martinholters commented 4 years ago

Modulo a slightly more descriptive entry in the README this looks good to me. If want, you can include a version bump in Project.toml and we make a release immediately after merging.

tkf commented 4 years ago

Thanks for the review. I updated the version number.

martinholters commented 4 years ago

Thanks!