search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
145 stars 117 forks source link

add isdisjoint (https://github.com/JuliaLang/julia/pull/34427/) #695

Closed colinxs closed 4 years ago

colinxs commented 4 years ago

Code copied from https://github.com/JuliaLang/julia/blob/098ef24c7acb989cae2516ac18bff498e9a69554/base/abstractset.jl#L390

I also had to add hasfastin (added in https://github.com/JuliaLang/julia/pull/32003), which isdisjoint depends on. I wasn't sure what the protocol was for non-exported functions so I added a separate if statement for hasfastin that just aliases Base.hasfastin if VERSION >= v"1.4.0-DEV.29".

martinholters commented 4 years ago

Meh, I tried to resolve the conflicts, but the Github online editor seems to have some trouble with the runtests.jl file.

martinholters commented 4 years ago

Ok, did the merge locally and while at it also added the missing link to the README. Should be good to go from my side assuming I haven't messed up the conflict resolution.

colinxs commented 4 years ago

Sorry for missing this! Thanks for getting it merged.

martinholters commented 4 years ago

Thanks for submitting it.