Add `Dates.canonicalize(::Period)`

JuliaLang / Compat.jl

Compatibility across Julia versions

Other

145 stars 117 forks source link

Add `Dates.canonicalize(::Period)` #726

Closed nickrobinson251 closed 3 years ago

nickrobinson251 commented 3 years ago

Added to Dates stdlib in https://github.com/JuliaLang/julia/pull/37391

martinholters commented 3 years ago

https://github.com/JuliaLang/julia/pull/37391 brings some more tests. Would it make sense to also include them here?

nickrobinson251 commented 3 years ago

JuliaLang/julia#37391 brings some more tests. Would it make sense to also include them here?

🤷‍♂️ I can bring them across if you like? I didn't since one test is enough to test the dispatch this PR adds (and those other tests are testing that the canonicalize logic in Dates produces the expected results). Would you prefer i bring them across to match the linked PR? :)

martinholters commented 3 years ago

Yes, I think I'd prefer to bring them along. We can easily afford the extra run-time that costs and it would help catch any nasty surprises.

nickrobinson251 commented 3 years ago

Cool :) i've brought over all the tests from the original PR and rebased to resolve conflicts