JuliaLang / Compat.jl

Compatibility across Julia versions

Other

144 stars 117 forks source link

Let `muladd` accept arrays #729

Closed mcabbott closed 3 years ago

mcabbott commented 3 years ago

This adds https://github.com/JuliaLang/julia/pull/37065 ... and https://github.com/JuliaLang/julia/pull/38250 now.

simeonschaub commented 3 years ago

Don't we have a 5-arg mul! in Compat now? Couldn't we just use that for compatibility with all older versions?

mcabbott commented 3 years ago

Yes we do, and I guess this uses it on early enough versions. But test failures earlier were from recursive dot issues.

simeonschaub commented 3 years ago

Ah, I see!

mcabbott commented 3 years ago

Test failure on MacOS nightly looks to be that it has a too-old nightly, it passes locally.

It might be possible to make the definitions here work on nightly versions between the two PRs above, but won't be easy to avoid ambiguities, and that doesn't seem like a great use of time.

mcabbott commented 3 years ago

(Sorry about the noise! Was trying to re-trigger travis. But it seems to be out of credit, in fact.)

mcabbott commented 3 years ago

Bump? CI looks happy, tests pass locally on 1.3, 1.4, 1.5.

oxinabox commented 3 years ago

Bump

codecov-commenter commented 3 years ago

Codecov Report

Merging #729 (46515c0) into master (61726a3) will increase coverage by 0.70%. The diff coverage is 89.74%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   80.64%   81.34%   +0.70%     
==========================================
  Files           4        4              
  Lines         465      504      +39     
==========================================
+ Hits          375      410      +35     
- Misses         90       94       +4

Impacted Files	Coverage Δ
src/Compat.jl	`81.44% <89.74%> (+0.80%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61726a3...46515c0. Read the comment docs.