Support 2-arg argmin/argmax/findmin/findmax

JuliaLang / Compat.jl

Compatibility across Julia versions

Other

144 stars 117 forks source link

Support 2-arg argmin/argmax/findmin/findmax #738

Closed timholy closed 3 years ago

timholy commented 3 years ago

xref https://github.com/JuliaLang/julia/pull/35316

Thanks for adding this to Julia, @cmcaine! I like it so much I want to use it for packages that support current/older Julia versions.

timholy commented 3 years ago

Now passing tests :1st_place_medal: (previous failures were unrelated, but fixed in #739).

ericphanson commented 3 years ago

Since Compat had a release with this, updating to https://github.com/JuliaLang/julia/pull/41076 will mean Compat v4, right? (I’m actually using the Compat v3 version in some code so I am concerned about breakage).