search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
144 stars 117 forks source link

Fix 2-arg argmin/argmax/findmin/findmax #748

Closed omus closed 3 years ago

omus commented 3 years ago

Updates #738 to use the changes made to https://github.com/JuliaLang/julia/pull/41076. Fixes https://github.com/JuliaLang/Compat.jl/issues/745.

codecov[bot] commented 3 years ago

Codecov Report

Merging #748 (b9aa87b) into master (78bba10) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files           4        4           
  Lines         513      513           
=======================================
  Hits          419      419           
  Misses         94       94
Impacted Files Coverage Δ
src/Compat.jl 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78bba10...b9aa87b. Read the comment docs.

omus commented 3 years ago

As discussed in https://github.com/JuliaLang/Compat.jl/issues/745#issuecomment-866862784 although the behaviour of Compat.jl is changing this counts as non-breaking as the original behaviour was never officially released.

omus commented 3 years ago

News entry was missing from the original #738

omus commented 3 years ago

As this is a bugfix I've marked it as such. If someone cared to do so this could be backported as 3.26.1