search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
144 stars 117 forks source link

Add support for Base.display_error over ExceptionStack. #756

Closed Sacha0 closed 2 years ago

Sacha0 commented 2 years ago

https://github.com/JuliaLang/Compat.jl/pull/746 added support for current_exceptions/ExceptionStack (née catch_stack), and augmented a few functions with methods that commonly handle ExceptionStacks. This pull request extends that to support to Base.display_error, which also commonly handles ExceptionStacks. Best! :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #756 (b09d8a5) into master (15191cb) will increase coverage by 0.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   78.35%   78.56%   +0.20%     
==========================================
  Files           4        4              
  Lines         633      639       +6     
==========================================
+ Hits          496      502       +6     
  Misses        137      137
Impacted Files Coverage Δ
src/Compat.jl 78.53% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15191cb...b09d8a5. Read the comment docs.

Sacha0 commented 2 years ago

It looks like Julia 1.1 lacks Base.scrub_repl_backtrace; I will guard the new definition and associated test to limit those to >= Julia 1.2.

Sacha0 commented 2 years ago

CI appears happy now; review much appreciated :).

Sacha0 commented 2 years ago

Rebased over https://github.com/JuliaLang/Compat.jl/pull/758. What say you, CI? :)

Sacha0 commented 2 years ago

@c42f, might I trouble you to have a look at this related patch as well? Thanks again! :)