JuliaLang / Compat.jl

Compatibility across Julia versions
Other
144 stars 117 forks source link

Remove deprecations, weed out dependencies #765

Closed martinholters closed 2 years ago

martinholters commented 2 years ago

Closes #764, which is the sole motivation for this PR at this point. Although I wouldn't expect anyone to be relying on those deprecations, it's technically breaking, so bumps the major version to 4.

Going forward, we might pick up new dependencies if we add compat code for other stdlibs. If we want to avoid that, we could think about introducing individual compat packages like CompatDates, CompatLinearAlgebra etc., But let's cross that bridge when we get there---if ever; the relatively small number of dependencies we have now should hopefully be ok.

codecov[bot] commented 2 years ago

Codecov Report

Merging #765 (5709a75) into master (fa274f7) will increase coverage by 0.23%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   79.00%   79.24%   +0.23%     
==========================================
  Files           4        3       -1     
  Lines         662      660       -2     
==========================================
  Hits          523      523              
+ Misses        139      137       -2     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa274f7...5709a75. Read the comment docs.

martinholters commented 2 years ago

Before going ahead here, I'd like to get some feedback; bumping the major version shouldn't be done too easily.

KristofferC commented 2 years ago

It seems like an accident that these are still here since the binding was removed in 1.0 and AFAIU this package dropped everything before that.

Also, since 1.6 is the LTS and we are doing a breaking version, I would suggest removing everything that has to do with the pre 1.6 era. This would for example allow us to drop the Test dependency as well.

martinholters commented 2 years ago

I would suggest removing everything that has to do with the pre 1.6 era. This would for example allow us to drop the Test dependency as well.

I like that. Packages still supporting pre-1.6 julia could nevertheless use almost everything Compat supports now and at the same time declare compatibility with the new, trimmed down Compat version. Only things that were not exported by Compat and hence accessed with explicit qualification would be problematic. Still, we probably shouldn't rush this. But this PR has been sitting idle for more than a month, so nobody is rushing anything here :smile:

I'll add a commit dropping anything pre-1.6 so we can see what it feels like.

martinholters commented 2 years ago

I'll add a commit dropping anything pre-1.6 so we can see what it feels like.

Opened separate PR at #767 instead.

martinholters commented 2 years ago

Superseded by #767.