Closed mcabbott closed 2 years ago
Merging #766 (177f169) into master (a2de107) will increase coverage by
0.09%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 78.90% 79.00% +0.09%
==========================================
Files 4 4
Lines 659 662 +3
==========================================
+ Hits 520 523 +3
Misses 139 139
Impacted Files | Coverage Δ | |
---|---|---|
src/Compat.jl | 79.03% <100.00%> (+0.10%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a2de107...177f169. Read the comment docs.
Bump, can this be merged?
BTW, using this seems to cause https://github.com/JuliaDiff/ChainRules.jl/issues/598 . I've no idea why, though.
I have no idea what's going on, but https://github.com/JuliaDiff/ChainRules.jl/issues/598#issuecomment-1063935985 says:
This wasn't an issue with Compat either, but with an older version of JuliaFormatter in my startup.jl!
And I failed to reproduce the problem. If someone can come up with a reproducer, I'm willing to look at it, but I doubt it's Compat's fault.
Thanks for looking. I can't reproduce it either, but just wondered if you (or anyone) had ever seen something like this. I see nothing wrong with what either package is doing.
This adds https://github.com/JuliaLang/julia/pull/43354, which is in Julia 1.8