Closed bkamins closed 2 years ago
Merging #774 (e64e132) into release-3 (95ea27f) will increase coverage by
0.00%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## release-3 #774 +/- ##
==========================================
Coverage 79.68% 79.69%
==========================================
Files 4 4
Lines 704 714 +10
==========================================
+ Hits 561 569 +8
- Misses 143 145 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/Compat.jl | 79.67% <80.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 95ea27f...e64e132. Read the comment docs.
It does not make much sense to put this on master, as the popat!
has been added in Julia 1.5 and Compat master requires Julia 1.6 now. But I'm fine with directly adding it to the release-3 branch. Let me try to change the PR accordingly...
Took the liberty to rebase the branch accordingly and fix the README a bit, please double-check.
It does not make much sense to put this on master, as the popat! has been added in Julia 1.5 and Compat master requires Julia 1.6 now.
Right - makes sense.
Thank you for rebasing - all looks good.
@nalimilan - OK to merge and make a release?
@martinholters Can we just tag a 3.45.0?
@martinholters Can we just tag a 3.45.0?
Sure, that was the idea of bumping the version in this PR.
Later it will require backporting.