search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
142 stars 117 forks source link

add `Splat` #785

Closed MasonProtter closed 1 year ago

MasonProtter commented 1 year ago

Ref: https://github.com/JuliaLang/julia/pull/42717

codecov[bot] commented 1 year ago

Codecov Report

Merging #785 (c885289) into master (abce98e) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   91.69%   91.86%   +0.16%     
==========================================
  Files           2        2              
  Lines         253      258       +5     
==========================================
+ Hits          232      237       +5     
  Misses         21       21
Impacted Files Coverage Δ
src/Compat.jl 92.40% <100.00%> (+0.16%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mcabbott commented 1 year ago

After https://github.com/JuliaLang/julia/pull/48038 this should probably export some lower-case splat function. Probably its own Compat.splat, not the existing Base.splat.

martinholters commented 1 year ago

Ah, this is quite unfortunate. Un-exporting Splat would technically be breaking. So I guess we should just keep Splat and and add splat and change the documentation to only mention splat?

Probably its own Compat.splat, not the existing Base.splat.

And why is that?