search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
142 stars 117 forks source link

Add `splat` #786

Closed martinholters closed 1 year ago

martinholters commented 1 year ago

Ref. #785 and JuliaLang/julia#48038.

cc @MasonProtter and @mcabbott

codecov[bot] commented 1 year ago

Codecov Report

Merging #786 (21b2df9) into master (5e16dfb) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   91.86%   91.92%   +0.06%     
==========================================
  Files           2        2              
  Lines         258      260       +2     
==========================================
+ Hits          237      239       +2     
  Misses         21       21
Impacted Files Coverage Δ
src/Compat.jl 92.46% <100.00%> (+0.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

martinholters commented 1 year ago

Should probably get #787 in first, to have a CI run with 1.9 on this one.

martinholters commented 1 year ago

Ok, CI looks good (including on 1.9), so good to go from my side.

martinholters commented 1 year ago

Our tests currently fail on Julia 1.9 and master because they test for Splat. With the development here being relatively slow, fixing it is not too urgent, but I'd nevertheless to do so soonish by merging this PR, unless anyone objects.