search

JuliaLang / Compat.jl

Compatibility across Julia versions
Other
145 stars 117 forks source link

[release-3] Put uses of `@pure` and `@_pure_meta` behind `@static if` #792

Closed martinholters closed 1 year ago

martinholters commented 1 year ago

Ref. https://github.com/JuliaLang/julia/pull/48682#issuecomment-1435515671. This makes Compat at least load again on Julia master.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-3@7463409). Click here to learn what that means. The diff coverage is n/a.

@@             Coverage Diff              @@
##             release-3     #792   +/-   ##
============================================
  Coverage             ?   81.54%           
============================================
  Files                ?        4           
  Lines                ?      791           
  Branches             ?        0           
============================================
  Hits                 ?      645           
  Misses               ?      146           
  Partials             ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

martinholters commented 1 year ago

Tests still fail on Julia nightly, but at least, loading works, so this should fix the immediate problems in the ecosystem.

Fixing the tests might still be worthwhile but is less urgent and therefore should happen separately.

martinholters commented 1 year ago

Test fix is at #794 (I hope). If that works, I'll merge that one first, then verify tests pass here as well, merge this and tag.

If any problems in #794 show up, I'll merge this as is and tag.