Closed martinholters closed 7 months ago
To run nanosoldier on this PR, a Compat.jl admin needs to get a secret from @maleadt to install the webhook on the repo: https://github.com/JuliaCI/Nanosoldier.jl/tree/master/res#repository-configuration. Then you can trigger it following https://github.com/JuliaCI/Nanosoldier.jl#reverse-ci-for-packages
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
db2077e
) 92.83% compared to head (165e032
) 95.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
To run nanosoldier on this PR, a Compat.jl admin needs to get a secret from @maleadt to install the webhook on the repo: https://github.com/JuliaCI/Nanosoldier.jl/tree/master/res#repository-configuration. Then you can trigger it following https://github.com/JuliaCI/Nanosoldier.jl#reverse-ci-for-packages
Ah. @KristofferC are you an admin for this repo and can you do that?
Let's try this:
@nanosoldier runtests()
Update on PkgEvalJob JuliaLang/Compat.jl@165e032 vs. JuliaLang/Compat.jl@db2077e: Accepted
Update on PkgEvalJob JuliaLang/Compat.jl@165e032 vs. JuliaLang/Compat.jl@db2077e: Running
The package evaluation job you requested has completed - possible new issues were detected. The full report is available.
Two PkgEval failures (ITensorVisualizationBase and ITensorGaussianMPS), both caused by
[1] permutedims_combine_output(...)
@ NDTensors ~/.julia/packages/NDTensors/kR4oQ/src/blocksparse/blocksparsetensor.jl:439
Thanks to @LilithHafner for actually reading the README, I'm totally fine with merging this, but we might want to give a heads-up at NDTensors.
This reverts commit c59d116e7039db494ac61548a52651f3d8ba7b30. Closes #811.
This is likely to break NDTensors, but might still be considered a bugfix as it makes Compat behave more like most recent Julia, see discussion in #811.