JuliaLang / Downloads.jl

MIT License
89 stars 35 forks source link

Experiment: remove precompile workload #237

Closed KristofferC closed 7 months ago

KristofferC commented 7 months ago

In https://github.com/JuliaLang/julia/pull/53403, I have the issue that this precompile workload errors during CI because of some weird reason with mktemp:

      From worker 2:    ERROR: LoadError: SystemError: mktemp: Operation not permitted
      From worker 2:    Stacktrace:
      From worker 2:     [1] systemerror(p::Symbol, errno::Int32; extrainfo::Nothing)
      From worker 2:       @ Base ./error.jl:176
      From worker 2:     [2] systemerror
      From worker 2:       @ ./error.jl:175 [inlined]
      From worker 2:     [3] mktemp(parent::String; cleanup::Bool)
      From worker 2:       @ Base.Filesystem ./file.jl:676
      From worker 2:     [4] mktemp
      From worker 2:       @ ./file.jl:673 [inlined]
      From worker 2:     [5] mktemp()
      From worker 2:       @ Base.Filesystem ./file.jl:673
      From worker 2:     [6] top-level scope
      From worker 2:       @ ~/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-4a04df3954/share/julia/stdlib/v1.12/Downloads/src/Downloads.jl:471

This is to try out the PR without the workload. If it works, I am inclined to just remove this because the value of it is marginal at best.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.53%. Comparing base (05f9ec2) to head (56040d5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #237 +/- ## ========================================== - Coverage 89.70% 89.53% -0.18% ========================================== Files 5 5 Lines 583 583 ========================================== - Hits 523 522 -1 - Misses 60 61 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.