search

JuliaLang / Downloads.jl

MIT License
88 stars 34 forks source link

turn TCP_FASTOPEN back on if libcurl is new enough? #83

Open StefanKarpinski opened 3 years ago

StefanKarpinski commented 3 years ago

See https://github.com/JuliaLang/Downloads.jl/pull/76. For libcurl ≥ 7.74 it should be safe to turn on TCP_FASTOPEN even for FTP requests.

StefanKarpinski commented 3 years ago

I do still want to do this but we're not using a recent enough libcurl for this to be fixed, so I'm still waiting on that so that a) will actually benefit from this and b) can test both code paths with different Julia versions.

tecosaur commented 1 year ago

Now that 7.74 has been out for a while, would it be worth setting TCP_FASTOPEN again?

StefanKarpinski commented 1 year ago

Yeah, seems like we could, although it's a little unclear to me if it makes that much difference for downloads.