JuliaLang / FunctionWrappers.jl

Type stable and efficient wrapper of arbitrary Julia functions
Other
107 stars 10 forks source link

Replace unsafe assume calls with `@assert` #31

Closed vtjnash closed 8 months ago

vtjnash commented 8 months ago

An @assert is enough to convince LLVM to jump-thread this, without the need for unsafe code or llvmcall.

KristofferC commented 6 months ago

This seems like it could be a non-ideal change because one is not supposed to rely on the side effects of @assert. When we turn off @asserts in default builds this will stop working.