search

JuliaLang / JuliaDoc

28 stars 26 forks source link

Fix missing theme data in setup.py #17

Closed petercolberg closed 8 years ago

petercolberg commented 8 years ago

This commit includes README.md in the tarball generated with python3 setup.py sdist.

Further this fixes an error when generating a Debian source package:

sudo apt-get install python3-all-dev python3-stdeb
python3 setup.py --command-packages=stdeb.command sdist_dsc
petercolberg commented 8 years ago

The theme data is now installed as well.

petercolberg commented 8 years ago

@ViralBShah, @pao, and @garrison, could you review and merge this pull request, and tag an initial JuliaDoc version 0.1.0? This would make it much easier to package JuliaDoc for Debian, which is a prerequisite for getting Julia 0.4.0 into Debian.

petercolberg commented 8 years ago

@stevengj, in case you are co-maintaining JuliaDoc, could you take a look at pull request #17?

pao commented 8 years ago

What is your interest in independently packaging this? Build the docs, then forget it exists. It's basically on life support anyways--I think my crummy packages were the only ones that even used it outside the core, and core documentation will be moving away from Sphinx soon.

petercolberg commented 8 years ago

JuliaDoc is an external dependency for building Julia 0.4, and as a Python package it should be packaged separately for Debian.

pao commented 8 years ago

That's a very rules-lawyery interpretation of "external dependency." It's separated so we can use it more easily with ReadTheDocs, that's all. It's not needed at all to use Julia or read its documentation, and can only make the installation more confusing.

petercolberg commented 8 years ago

Debian differentiates between build dependencies and installation dependencies. The package would not be needed for installation of julia, but for compilation by the maintainer or build daemon. Since you mention that JuliaDoc will be deprecated soon, however, it seems better to embed it in the julia source.

petercolberg commented 8 years ago

Nevertheless, please review and merge the commits that fix setup.py.

pao commented 8 years ago

It's not clear to me what is being fixed, seeing as it currently works in both Julia's build system and on RTD. I'm more concerned about those things not suddenly breaking. Someone who understands what is being done here and is more sure of not screwing things up should take a look.