search

JuliaLang / JuliaSyntax.jl

The Julia compiler frontend
Other
274 stars 33 forks source link

Support for running JuliaSyntax on Julia 1.0 #182

Closed c42f closed 1 year ago

c42f commented 1 year ago

Mostly just compat changes here, adding a bunch of Base utility functions we use which don't exist in earlier Julia versions.

There's still a few failures in the extended tests, probably due to differences in line number node placement and the like in the reference parser.

Fix #180

davidanthoff commented 1 year ago

@c42f do you think it might make sense to just disable those tests for older Julia versions?

c42f commented 1 year ago

Yea. I was working on doing that in a surgical way, but I'm really not sure it's worth the effort at this point, to be honest.

Older Julia versions have some weird placing of line number nodes and some bugs in the reference parser (eg broken triple quoted string deindentation) which make comparison with the reference parser from those old versions quite annoying.

davidanthoff commented 1 year ago

Hurray! Could you also tag a new release?

My plan is to start incorporating this into the language server, simply for the nice syntax error messages. Does that sound good to you?

c42f commented 1 year ago

Sounds great to me!

New release tagged: https://github.com/JuliaRegistries/General/pull/76003