JuliaLang / JuliaSyntax.jl

The Julia compiler frontend
Other
274 stars 33 forks source link

Improve syntax diffing in General registry checker #216

Closed c42f closed 1 year ago

c42f commented 1 year ago

Now produces much more readable logs of broken syntax such as

┌ Error: Parsers succeed but disagree
│   fpath = "/home/c42f/.julia/dev/JuliaSyntax/tools/pkgs/TropicalYao_0.1.5/src/reversible/LogLikeNumbers/instructs.jl"
│   reduced_chunks =
│    end
│    
│    #          ┌─────────────────────────────────────────────────
│    @i @inline function (:*=(identity))(x::Tropical, y::Tropical)
│        (x |> content) += (y |> content)
│    end
│    #─┘

This is on top of https://github.com/JuliaLang/JuliaSyntax.jl/issues/215 - ignore the first commit.

codecov[bot] commented 1 year ago

Codecov Report

Merging #216 (e91dc14) into main (442f3e4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          15       15           
  Lines        3868     3868           
=======================================
  Hits         3726     3726           
  Misses        142      142           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

timholy commented 1 year ago

You presumably mean it's on top of #215? (#150 is the corresponding issue).

I struggle a bit to comprehend

Parsers succeed but disagreeyntax/tools/check_all_packages.jl:65

It seems like a file/line number is being used as part of a grammatical construction?

c42f commented 1 year ago

It seems like a file/line number is being used as part of a grammatical construction?

Hehe oops. That was a copy+paste error from the terminal where the progress bar printing corrupted the other printing due to ^C'ing the Julia process earlier.

And yes, this is on top of #215 apparently my brain wasn't working when I wrote the description :sweat_smile: