JuliaLang / JuliaSyntax.jl

The Julia compiler frontend
Other
272 stars 35 forks source link

unhandled kwargs throw errors #422

Open ericphanson opened 7 months ago

ericphanson commented 7 months ago

closes https://github.com/JuliaLang/JuliaSyntax.jl/issues/416

My editor is configured to remove trailing whitespace, which caused some diffs here. Let me know if that's too annoying and I'll undo it.

Locally I get the test failures:

Parse core.jl: Test Failed at /Users/eph/JuliaSyntax.jl/test/test_utils.jl:237
  Expression: parsers_agree

Parse core.jl: Test Failed at /Users/eph/JuliaSyntax.jl/test/test_utils.jl:241
  Expression: reduced_failures == []
   Evaluated: AbstractString["for f() in 1:3\n        push!(a, f())\n        push!(fs, f)\n    end", " {{}}where{}"] == Any[]

same as in #420, which I think are unrelated.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.17%. Comparing base (a6f2d15) to head (c63e9c7). Report is 47 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #422 +/- ## ========================================== + Coverage 94.61% 96.17% +1.56% ========================================== Files 14 14 Lines 4178 4185 +7 ========================================== + Hits 3953 4025 +72 + Misses 225 160 -65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.