Closed fredrikekre closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.84%. Comparing base (
ae7d6ac
) to head (df7221e
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Side note: [...]
This was a bit of a surprise to me actually. Since there are both Whitespace and Newline(Ws) tokens it seems a bit strange to have them combined. On the other hand, for the purpose of writing a code formatter it was rather convenient: Stripping trailing space is easy since I only need to find NewlineWs nodes, and indents is also easy for the same reason (no need to peek backwards and forward).
Also, can we have a new release including this and #455 ? Is there a reason releases aren't cut from the main branch? I am happy to do the backporting work to the release-0.4 branch but would be nice to get back to releasing from main I think.
We can have a new release, for sure. I've been working toward that in the past couple of days - merging a few fixes and getting in some changes I need for JuliaLowering.
If we make it from main
it'll be a breaking release, so I guess we may as well make it JuliaSyntax 1.0. If I don't get it done soon enough for your liking (I've been feeling overloaded!) you're welcome to backport the bugfixes to the release-0.4 branch and we can release that.
But I've been feeling like we should get back to releasing off main
- having the divergence between the release and main
has become a pain point.
Since there are both Whitespace and Newline(Ws) tokens it seems a bit strange to have them combined.
Yes it seems kinda odd right? We don't need to change it if it's convenient. But also it doesn't seem very clean :woman_shrugging:
Which PRs/commits are breaking?
main
)
Without this patch
\r\n\r\n
would be tokenized as\r\n\r
and\n
instead of\r\n
and\r\n
. Fixes https://github.com/fredrikekre/Runic.jl/issues/15.