JackDunnNZ commented 4 years ago

While https://github.com/JuliaLang/julia/pull/32706 is pending, it seems like it would be good to switch this over to the JLL package in the meantime (and the stdlib change won't happen for Julia 1.3 or 1.4).

This is adapted from @quinnj's work in jq/stdlib but uses the JLL rather than the Julia-provided library

cc @kmsquire who asked for this here: https://discourse.julialang.org/t/packagecompiler-jl-complaining-that-mbedtls-jl-might-not-be-relocatable/34878

KristofferC commented 4 years ago

Need to update julia compat in Project.toml and update what versions Travis tests.

codecov-io commented 4 years ago

Codecov Report

Merging #216 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   72.58%   72.63%   +0.04%     
==========================================
  Files          12       12              
  Lines         569      570       +1     
==========================================
+ Hits          413      414       +1     
  Misses        156      156

Impacted Files	Coverage Δ
src/MbedTLS.jl	`98.11% <ø> (ø)`	:arrow_up:
src/ssl.jl	`66.81% <100%> (+0.14%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44b812d...c0b439c. Read the comment docs.

JackDunnNZ commented 4 years ago

Whoops, thanks. I also removed the FORCE_BUILD builds since that's not relevant anymore

kmsquire commented 4 years ago

I'll add my thanks! Can someone please tag a release?

JuliaLang / MbedTLS.jl

Use MbedTLS_jll instead of BinaryProvider #216

Codecov Report