JuliaLang / MbedTLS.jl

Wrapper around mbedtls
Other
41 stars 50 forks source link

Switch default cert to MozillaCACerts_jll #238

Closed quinnj closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #238 (4bfad89) into master (838b657) will increase coverage by 0.46%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   71.34%   71.81%   +0.46%     
==========================================
  Files          12       12              
  Lines         541      699     +158     
==========================================
+ Hits          386      502     +116     
- Misses        155      197      +42     
Impacted Files Coverage Δ
src/MbedTLS.jl 98.21% <ø> (+0.21%) :arrow_up:
src/ssl.jl 67.14% <100.00%> (+1.23%) :arrow_up:
src/debug.jl 0.00% <0.00%> (-66.67%) :arrow_down:
src/error.jl 35.71% <0.00%> (-5.96%) :arrow_down:
src/entropy.jl 83.33% <0.00%> (-4.91%) :arrow_down:
src/rsa.jl 81.81% <0.00%> (-3.04%) :arrow_down:
src/pk.jl 80.00% <0.00%> (-0.49%) :arrow_down:
src/ctr_drbg.jl 84.00% <0.00%> (-0.22%) :arrow_down:
src/gen_constants.jl 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4261df...4bfad89. Read the comment docs.

fredrikekre commented 2 years ago

Looks like this caused https://discourse.julialang.org/t/precompile-errors-with-pkg-update-or-pkg-add-for-some-packages/83917 ?

giordano commented 2 years ago

For the record, the problem was due to the Arch Linux Julia package being thoroughly broken as usual and having missing files (or not adjusting variables to point to existing files in Arch system): https://discourse.julialang.org/t/problems-installing-packages-cert-pm-no-such-file/83995/4

fredrikekre commented 2 years ago

If bundling the cert has worked until now, perhaps worth at least falling back to that? Edit: #241