search

JuliaLang / MbedTLS.jl

Wrapper around mbedtls
Other
41 stars 50 forks source link

Fall back to bundled cacert.pem. #241

Closed fredrikekre closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #241 (1f3d37c) into master (0c02e44) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   71.81%   71.89%   +0.08%     
==========================================
  Files          12       12              
  Lines         699      701       +2     
==========================================
+ Hits          502      504       +2     
  Misses        197      197
Impacted Files Coverage Δ
src/ssl.jl 67.37% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c02e44...1f3d37c. Read the comment docs.

quinnj commented 2 years ago

Sorry, missed this PR. Yeah, this is a good idea. Do you think we should just fallback to the Julia-bundled cert instead of having our own at all?

fredrikekre commented 2 years ago

Yea that seems easier, didn't know there was one, thought it was only the one from the JLL

quinnj commented 2 years ago

Alternative PR proposed: https://github.com/JuliaLang/MbedTLS.jl/pull/246