search

JuliaLang / MbedTLS.jl

Wrapper around mbedtls
Other
41 stars 50 forks source link

handle normal stream EOF (TLS v1.3 feature) #248

Closed vtjnash closed 2 years ago

vtjnash commented 2 years ago

Implemented per mbedtls_ssl_read documentation: https://github.com/Mbed-TLS/mbedtls/blob/53546ea099f6f53d0be653a64accd250e170337f/include/mbedtls/ssl.h#L2999

codecov[bot] commented 2 years ago

Codecov Report

Merging #248 (ef4dc81) into master (dfd1108) will increase coverage by 2.38%. The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   71.85%   74.23%   +2.38%     
==========================================
  Files          12       12              
  Lines         707      718      +11     
==========================================
+ Hits          508      533      +25     
+ Misses        199      185      -14
Impacted Files Coverage Δ
src/ssl.jl 73.10% <56.25%> (+6.07%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

thchr commented 2 years ago

This indeed fixes the bug I had in https://github.com/JuliaWeb/HTTP.jl/issues/896. Thanks!

(HTTP.download("https://www.cryst.ehu.es/") still throws a StackOverflowError on this PR - but that seems to happen on earlier versions of MbedTLS as well, so is probably just an HTTP.jl issue)