search

JuliaLang / MbedTLS.jl

Wrapper around mbedtls
Other
41 stars 50 forks source link

Use Base.IOError more consistently for read/write operation failures #257

Closed quinnj closed 2 years ago

quinnj commented 2 years ago

Previously we might throw ArgumentError, MbedException, or AssertionError. This PR proposes we more closely follow Sockets stdlib behavior by making these errors Base.IOError for consistency.

Fixes https://github.com/JuliaLang/MbedTLS.jl/issues/188

codecov[bot] commented 2 years ago

Codecov Report

Merging #257 (e9fe500) into master (1cf08a2) will decrease coverage by 0.00%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   73.74%   73.73%   -0.01%     
==========================================
  Files          12       12              
  Lines         716      712       -4     
==========================================
- Hits          528      525       -3     
+ Misses        188      187       -1
Impacted Files Coverage Δ
src/ssl.jl 72.53% <66.66%> (-0.04%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.