search

JuliaLang / MbedTLS.jl

Wrapper around mbedtls
Other
41 stars 50 forks source link

pk/rsa: Fix GC rooting issues and fill out API #280

Open Keno opened 11 months ago

Keno commented 11 months ago

MbedTLS is passing raw pointers to C without rooting ownership all over the place. This fixes these issues in the pk/rsa code and fills out the API a bit for round-trip testing, as well as adding GC-safe wrappers over the internal mp integers for downstream code to use. Of course, the unsafe GC pattern is repeated elsewhere in this package, so this is just a first PR that fixed the API surface that I happened to need.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (41d1897) 76.22% compared to head (868c9ea) 77.09%. Report is 2 commits behind head on master.

Files Patch % Lines
src/rsa.jl 90.90% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #280 +/- ## ========================================== + Coverage 76.22% 77.09% +0.87% ========================================== Files 12 12 Lines 753 786 +33 ========================================== + Hits 574 606 +32 - Misses 179 180 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devmotion commented 8 months ago

@quinnj Bump 🙂

I would be very interested in the additions to the API (and the improvements, of course).