search

JuliaLang / Microbenchmarks

Microbenchmarks comparing the Julia Programming language with other languages
https://julialang.org/benchmarks/
Other
88 stars 48 forks source link

fix stata script #30

Closed floswald closed 6 years ago

floswald commented 6 years ago

i've seen that the stata benchmark does not run. i fixed a filename issue. it runs for me with

➜  Microbenchmarks git:(master) ✗ cat stata.csv
stata,fib,3
stata,parse_int,9
stata,quicksort,20
stata,mandel,10
stata,pi_sum,730
stata,rand_mat_stat,442.9999999999999
stata,rand_mat_mul,688
stata,fib_stata,272
stata,parse_int_stata,37
stata,quicksort_stata,610
stata,mandel_stata,512
stata,pi_sum_stata,118687

cheers

johnfgibson commented 6 years ago

Thanks for the PR. It looks good. I'll merge it and update the benchmark names to match recent changes (e.g. fib -> recursion_fibonacci).

However, I don't have a license for Stata on the machine that runs the benchmark suite. My university has a site license for Stata on Windows, but not Unix/Linux. Unless it matters enough to someone to buy or donate a Stata license for me, we probably won't get Stata results for the microbenchmarks. But I'll keep taking PRs to the Stata code to keep it current in case that changes.

floswald commented 6 years ago

yeah i imagined that the stata benchmark is not first order. buying a stata license to test how slow it is against an awesome open source language does sound kind of weird. :-)

floswald commented 6 years ago

oh and i didnt' touch the makefile as you can see mainly because of that (i.e who knows if you actually want to run this).