Closed atecon closed 2 years ago
Hi all, I wondering that nobody has answered on my pull request, yet. Could you please have a look at it? Thanks! Best, Artur
Hi, thanks for the contribution. I'm afraid that each additional benchmark here adds considerable maintenance burden. We can accept this if @johnfgibson, who has recently taken charge of running the benchmarks is willing to merge and test this. We already have more comparisons than we need.
Thanks for your answer, @StefanKarpinski.
@johnfgibson Would you be willing to test the Gretl benchmark in this case? If you need some help with it, please let me know.
By the way, here is some recent background on the Gretl project ;-) URL: https://sourceforge.net/blog/january-2019-staff-pick-project-month-gretl/
Best,, Artur
@atecon thanks for the PR.
As @StefanKarpinski previously mentioned adding more and more languages just increases the maintenance burden for us. To ease this burden for us, we have added CI to our pipeline (courtesy of @MilesCranmer) and it would be appropriate to enable your language in our CI code. However, there is a chance that even with those changes we may not want to merge this in as this repo is currently running in maintenance mode. If you would like gretl benchmarks against other languages maybe check out benchmarksgame.
Considering this is a stale PR and @johnfgibson has not responded either, I'll go ahead and close this PR. If anyone disagrees with this, please comment and we can open this PR back up.
We apologize for the late response.
Edit: I tried to look a bit closer at gretl and found the following description on their homepage:
gretl is a cross-platform software package for econometric analysis, written in the C programming language.
Is it essentially a framework of packages for C? In that case, I believe the C benchmark suffices.
Dear all, I would like to add a benchmark file for the open-source statistics and econometrics software Gretl (URL: http://gretl.sourceforge.net/). This is tested using the latest Gretl release 2018c.
I've added the perf.inp script-file and adapted further changes in the remaining files. I hope this works fine.
Best, Artur