search

JuliaLang / Microbenchmarks

Microbenchmarks comparing the Julia Programming language with other languages
https://julialang.org/benchmarks/
Other
88 stars 48 forks source link

Test for Java irrelevant #33

Closed IRus closed 2 years ago

IRus commented 5 years ago

Consider use of JMH for java performance tests. Also, use latest stable JVM for tests.

see https://github.com/JuliaLang/julia/issues/19460 proposed PR for main repo (which was ignored): https://github.com/JuliaLang/julia/pull/20984

acxz commented 2 years ago

Consider use of JMH for java performance tests.

Quoting @StefanKarpinski 's comment here:

Absent evidence that what we're timing is actually wrong, we're not going to make that change ourselves. Of course, if you want to submit a PR that changes the benchmark code to use JMH, that would be welcomed (assuming we can get it to compile and run without too much trouble).

I know you must have put in some good effort in making the benchmarks more idiomatic for java in your previous PR, however, we are trying to keep things a bit simple this repo, especially since this repo is essentially in maintenance mode. Again feel free to rewrite your PR to use JMH for this repo, but there honestly is not much merit in doing so and a strong chance that we won't accept it (or just let it sit). If you would to like see thorough and more complete benchmarks I suggest you to take a look at benchmarkgames.

Also, use latest stable JVM for tests.

This has been accomplished with the lastest changes to this repo's CI.

If you still have other concerns feel free to comment! Closing for now though.