search

JuliaLang / Microbenchmarks

Microbenchmarks comparing the Julia Programming language with other languages
https://julialang.org/benchmarks/
Other
88 stars 48 forks source link

[Go]: migrate to gonum.org/v1 packages #55

Closed acxz closed 2 years ago

acxz commented 2 years ago

This is to update go tests so that we can get them up and running in the CI.

Supersedes and closes #27

MilesCranmer commented 2 years ago

Nice work! Looks good to me.

acxz commented 2 years ago

@MilesCranmer do you know who to ping to get these PRs merged in?

There are quite a few of them and I'd like to check them off.

MilesCranmer commented 2 years ago

I think @DilumAluthge @giordano @johnfgibson have write access here but am not sure who else. @StefanKarpinski + @ViralBShah look to have merged the most recent code to the go benchmark but not sure if they have bandwidth.

ViralBShah commented 2 years ago

Yeah I can take a look. @acxz I can give you write access to the repo. Could you review all the outstanding PRs and merge those that are good to go and close others/ask for updates?

acxz commented 2 years ago

@ViralBShah that would be great as I currently have the cycles for keeping up with this repo.

At this point, my focus will just be to fix up the existing issues with the codebase and keep it up to date with changes such as syntax.

DilumAluthge commented 2 years ago

I've added you.

acxz commented 2 years ago

Looks like it might take a while for github to register to change, I'll confirm tomorrow morning.

DilumAluthge commented 2 years ago

You have to accept the invite manually. Did you get an email from GitHub?

acxz commented 2 years ago

As of yet, I have not gotten an email from GitHub.

ViralBShah commented 2 years ago

You should be able to see the invitation in your github account - at github.com/acxz or something like that (on top of the screen). And maybe check that you have the right email on your github account?

ViralBShah commented 2 years ago

Maybe try here: https://github.com/JuliaLang/Microbenchmarks/invitations

acxz commented 2 years ago

I checked and confirmed both my profile and my email. Still nothing, this is quite weird.

I got the following error:

invitation-not-found

ViralBShah commented 2 years ago

I think the invite had been sent mistakenly to aczx instead of acxz... Check now.

acxz commented 2 years ago

Yep just received it. Thanks!

DilumAluthge commented 2 years ago

🤦 That's on me. Thanks for catching that Viral!

acxz commented 2 years ago

CI passes with updated Go changes. Merging in.