search

JuliaLang / Microbenchmarks

Microbenchmarks comparing the Julia Programming language with other languages
https://julialang.org/benchmarks/
Other
88 stars 48 forks source link

fix benchmarks link on julia website #61

Closed acxz closed 2 years ago

acxz commented 2 years ago

Benchmarks are not located on the homepage anymore

The website does not include the table anymore

acxz commented 2 years ago

Considering the output of the table.jl file is not used, I believe it makes sense to actually remove the file.

LilithHafner commented 2 years ago

A table is still available here: https://julialang.org/assets/benchmarks/benchmarks.csv. I think we should link to those tabular results directly from README.md. When I saw this repo, one of the first things I wanted to see was tabular results on someone else's machine.

I also think table.jl is also needed for regression testing so we can't remove it (see failed CI run for this PR): 

make: *** No rule to make target 'bin/table.jl', needed by 'gh_action_benchmarks.html'.  Stop.
acxz commented 2 years ago

A table is still available here:

This is actually the csv file and not the table. The csv file is not displayed anywhere on the website and the plan is to delete this file in a future PR to www.julialang.org once #62 is merged.

I think we should link to those tabular results directly from README.md.

This may be a good idea however, it is outside the scope of this PR. Edit: Actually we could just slap the html table onto the readme, hmm.... let's see what other reviewers have to say. In the meanwhile we'll keep the unused bin/table.jl file around.

I also think table.jl is also needed for regression testing so we can't remove it

Good catch, let me fix real quick.