JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.42k stars 189 forks source link

add warning about threading issue #781

Closed IanButterworth closed 2 months ago

IanButterworth commented 1 year ago

Fixes #778

IIUC in non-incremental (--sysimage=*.ji) mode with stdlibs filtered out, julia has to do a lot more bootstrapping, which may max out all available threads, so not maxing out all threads during each Pkg.precompile subprocess isn't guaranteed, so it's best to warn the user to just be conservative with enabling threading.

cc. @vtjnash

codecov[bot] commented 1 year ago

Codecov Report

Merging #781 (0301e62) into master (8e4c03c) will decrease coverage by 0.10%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   83.00%   82.90%   -0.10%     
==========================================
  Files           3        3              
  Lines         665      667       +2     
==========================================
+ Hits          552      553       +1     
- Misses        113      114       +1     
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.95% <50.00%> (-0.17%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JeffBezanson commented 1 year ago

We should just fix this for real instead!

sjkelly commented 2 months ago

I am pretty sure this is fixed!