Pass CPU targets as cmdline args

JuliaLang / PackageCompiler.jl

Compile your Julia Package

https://julialang.github.io/PackageCompiler.jl/dev/

MIT License

1.43k stars 191 forks source link

Pass CPU targets as cmdline args #804

Closed ven-k closed 1 year ago

ven-k commented 1 year ago

Fixes #790
JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2
Sysimages built with CPU targets as env var, tend to ignore them and result segfaults, when relocated to the target machine (See^1) (On Julia#master and Julia#backports-release-1.9)
I've locally tested the PR against Julia binary^2 associated with latest commit^3 on Backport to 1.9 PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #804 (bb14715) into master (ef46e40) will decrease coverage by 0.39%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   82.98%   82.59%   -0.39%     
==========================================
  Files           3        3              
  Lines         670      655      -15     
==========================================
- Hits          556      541      -15     
  Misses        114      114

Impacted Files	Coverage Δ
src/PackageCompiler.jl	`92.78% <100.00%> (-0.21%)`	:arrow_down:

ven-k commented 1 year ago

Once the next release of 1.9.0-* is out, 'will re-run the corr. tests.

The failure^1 on 1.10-dev is unrelated

filter = false: Error During Test at D:\a\PackageCompiler.jl\PackageCompiler.jl\test\runtests.jl:80
Got exception outside of a @test
Unable to automatically download/install artifact 'fooifier' from sources listed in 'C:\Users\runneradmin\AppData\Local\Temp\jl_kTjrxv\MyApp\Artifacts.toml'.
Sources attempted:
- https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
  Error: RequestError: HTTP/1.1 404 Not Found while requesting https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
- https://github.com/staticfloat/small_bin/raw/master/libfoo/libfoo.x86_64-w64-mingw32.tar.gz
  Error: Tree Hash Mismatch!
Expected git-tree-sha1:   d61f806c76b57e54f343634c5219d00d4c81b077
Calculated git-tree-sha1: 1[351](https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:354)b831192db9091d97e9b4bc84231ade05d210

KristofferC commented 1 year ago

JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2

Is there an upstream issue regarding this?

KristofferC commented 1 year ago

The CI error seems relevant or?

ERROR: More than one command line CPU targets specified without a `--output-` flag specified
PackageCompiler.jl: Error During Test at /home/runner/work/PackageCompiler.jl/PackageCompiler.jl/test/runtests.jl:36

ven-k commented 1 year ago

The ERROR: More than one command line CPU targets specified without a--output-flag specified : this comment and #790 describe the issue.
https://github.com/JuliaLang/julia/pull/48809 fixes that. But it isn't part of 1.9.0-rc2. Rn, it's enlisted here: https://github.com/JuliaLang/julia/pull/49302. And backported with this commit https://github.com/JuliaLang/julia/pull/49302/commits/9aa766900f3dbf10843717543e033d86ab5a1c93
However, https://github.com/JuliaLang/julia/pull/48809 doesn't fix the failing case of JULIA_CPU_TARGET. See this comment.