search

JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.41k stars 189 forks source link

Add `import_to_main` flag for Main module package name conflicts resolution #807

Open krynju opened 1 year ago

krynju commented 1 year ago

This contains only the import_to_main part of https://github.com/JuliaLang/PackageCompiler.jl/pull/794

Fixes https://github.com/JuliaLang/PackageCompiler.jl/issues/768

Changelog:

  1. added import_into_main flag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimage
  2. added skip & warnings on the import to Main name conflict https://github.com/JuliaLang/PackageCompiler.jl/issues/768
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.64%. Comparing base (8e57908) to head (c68f67b).

:exclamation: Current head c68f67b differs from pull request most recent head c255bdc. Consider uploading reports for the commit c255bdc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #807 +/- ## ======================================= Coverage 84.64% 84.64% ======================================= Files 3 3 Lines 827 827 ======================================= Hits 700 700 Misses 127 127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

krynju commented 1 year ago

@KristofferC Can we merge and tag this? I confirmed it works fine on my case