search

JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.41k stars 189 forks source link

fix importing executable before trying to compile its `julia_main` #813

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

Fixes #812

codecov[bot] commented 1 year ago

Codecov Report

Merging #813 (22f7d1e) into master (33428b2) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files           3        3           
  Lines         655      655           
=======================================
  Hits          541      541           
  Misses        114      114
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.80% <100.00%> (+0.01%) :arrow_up:

... and 1 file with indirect coverage changes

IanButterworth commented 1 year ago

Why wasn't this causing test failures?

KristofferC commented 1 year ago

It only happens when you have no compilation for the app.