only bundle libraries that are needed

JuliaLang / PackageCompiler.jl

Compile your Julia Package

https://julialang.github.io/PackageCompiler.jl/dev/

MIT License

1.41k stars 189 forks source link

only bundle libraries that are needed #823

Closed KristofferC closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #823 (863d970) into master (dff7b2c) will increase coverage by 1.43%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   82.59%   84.03%   +1.43%     
==========================================
  Files           3        3              
  Lines         655      714      +59     
==========================================
+ Hits          541      600      +59     
  Misses        114      114

Impacted Files	Coverage Δ
src/PackageCompiler.jl	`93.54% <100.00%> (+0.74%)`	:arrow_up:

KristofferC commented 1 year ago

I think this should be ready to go.

sloede commented 1 year ago

Out of curiosity, what will this PR being to PC.jl? From the title I assume it will improve somehow which libraries are bundled with a sysimage, but I can't tell from looking at the code 😬

KristofferC commented 1 year ago

It will:

Only bundle libraries for jlls that are actually used in the resulting sysimage
It will fix https://github.com/JuliaLang/PackageCompiler.jl/issues/725.

sloede commented 1 year ago

It will:

Only bundle libraries for jlls that are actually used in the resulting sysimage

It will fix too much stuff generated by default #725.

Great, thanks!