[WIP] Allow setting a command prefix for the sysimage build command

JuliaLang / PackageCompiler.jl

Compile your Julia Package

https://julialang.github.io/PackageCompiler.jl/dev/

MIT License

1.4k stars 186 forks source link

[WIP] Allow setting a command prefix for the sysimage build command #870

Open sloede opened 9 months ago

sloede commented 9 months ago

This PR adds a new, optional sysimage_build_prefix kwarg to create_{sysimage,app,library}. It aims to allow one to prepend the build command called when creating a sysimage with a user-specified command prefix.

The main motivation is to be able to call PackageCompiler.jl from within an MPI-started process. This is sometimes required on supercomputers, where calling MPI functions without having started a process via mpirun/srun/aprun etc. is disabled.

cc @lchristm

codecov[bot] commented 9 months ago

Codecov Report

Merging #870 (38c58d8) into master (846292c) will decrease coverage by 0.68%. Report is 4 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   84.94%   84.26%   -0.68%     
==========================================
  Files           3        3              
  Lines         797      801       +4     
==========================================
- Hits          677      675       -2     
- Misses        120      126       +6

Files	Coverage Δ
src/PackageCompiler.jl	`92.57% <100.00%> (-0.87%)`	:arrow_down:

lchristm commented 9 months ago

@sloede The prefix is only needed for executing scripts passed via precompile_execution_file and not for building the system image afterwards. I changed the PR branch accordingly but I think it would be reasonable to change the PR title as well.