search

JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.4k stars 186 forks source link

Tweak how `IS_OFFICIAL` is determined (unbreaks Julia 1.11) #883

Closed Drvi closed 9 months ago

Drvi commented 9 months ago

In https://github.com/JuliaLang/julia/pull/51867, the banner function moved to the REPL module, breaking precompilation.

Perhaps there is a better way to know whether we are on an official build, but we're trying to resolve this issue to unblock our nightly CI.

codecov[bot] commented 9 months ago

Codecov Report

Merging #883 (394f150) into master (037a72e) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   84.28%   84.26%   -0.02%     
==========================================
  Files           3        3              
  Lines         802      801       -1     
==========================================
- Hits          676      675       -1     
  Misses        126      126
Files Coverage Δ
src/PackageCompiler.jl 92.57% <ø> (ø)

... and 1 file with indirect coverage changes

KristofferC commented 9 months ago

Thanks LGTM. There is indeed probably a better way but let's just fix it for now.