Closed sloede closed 3 months ago
I'm not an admin so can't see repo settings, I'm afraid
I can set up the token. But why do we need to upgrade to v4 of the action? Can't we just stay on v3 (which supports tokenless uploads)?
I can set up the token. But why do we need to upgrade to v4 of the action? Can't we just stay on v3 (which supports tokenless uploads)?
In my experience, the codecov-action has been somewhat brittle in the past (but YMMV). Therefore, in my other repos we try to stick to the latest support version. Also, all the docs are by now referring to v4-specific details, making it slightly more confusing when sticking with v3. Tokenless uploads are still supported for PRs from forks, so that should still work.
Having said that, I have no strong feelings either way here 🤷♂️
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8cd96a1
) 84.62% compared to head (fefaab9
) 84.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A token-based auth seems better than whatever was done before. The coverage results appear to upload correctly, so merging this. Thanks!
Supersedes #921.
TODO:
CODECOV_TOKEN
before merging.