Open sjkelly opened 3 months ago
Attention: Patch coverage is 96.15385%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 85.19%. Comparing base (
8cd96a1
) to head (15b3656
).
Files | Patch % | Lines |
---|---|---|
src/PackageCompiler.jl | 96.15% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is intended to be an API-compatible refactor to make future extensibility and configuration of PackageCompiler.jl far simpler. The core idea is to implement a configuration process, and corresponding output datatype to be consumed by the build process.
This conceptually splits the process of building sysimg/app/libs, from the high-level logic determining names, build tools, flags, etc. The benefit of this is that it immediately commonizes code that was duplicated amongst the three of:
create_sysimage
,create_library
, andcreate_app
. It will also make it far simpler to allow for configuration and propagation of flags likeldflags
andcflags
which are currently not easily exposed in the build process.This is a rough sketch of the idea, and so far the API seems to be preserved acceptably. Feedback and design input would be much appreciated. I suspect the
Conf
type may need some indication ofmode
since some terms are overloaded and may not make sense to define in all contexts.