JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.42k stars 188 forks source link

Change naming convention of object files to follow what Base Julia does #930

Open gbaraldi opened 6 months ago

gbaraldi commented 6 months ago

Fixes #738

I'm not sure why this makes macos broken, but given that the fix is simple I'm also not going to dig into it.

The tests don't all pass because fooifier isn't there for macos, @staticfloat would need to rebuild it or we just switch to another random artifact.

It also prints a bunch of

ld: warning: no platform load command found in '/var/folders/fs/z9fkqy2n5djg4663njw_c20m0000gn/T/jl_4TmZI5eNyL-o.a[2](text#0.o)', assuming: macOS
ld: warning: no platform load command found in '/var/folders/fs/z9fkqy2n5djg4663njw_c20m0000gn/T/jl_4TmZI5eNyL-o.a[3](text#1.o)', assuming: macOS
ld: warning: no platform load command found in '/var/folders/fs/z9fkqy2n5djg4663njw_c20m0000gn/T/jl_4TmZI5eNyL-o.a[4](text#2.o)', assuming: macOS
ld: warning: no platform load command found in '/var/folders/fs/z9fkqy2n5djg4663njw_c20m0000gn/T/jl_4TmZI5eNyL-o.a[5](text#3.o)', assuming: macOS
ld: warning: no platform load command found in '/var/folders/fs/z9fkqy2n5djg4663njw_c20m0000gn/T/jl_4TmZI5eNyL-o.a[6](text#4.o)', assuming: macOS

Which was fixed by https://github.com/JuliaLang/julia/pull/51830 but that didn't get backported into 1.10.

staticfloat commented 6 months ago

For the fooifier stuff, probably best to just use a JLL like HelloWorldC_jll or something like that. We don't want to actually add it as a dependency though, we want to embed the Artifacts.toml file directly, to continue testing the artifacts handling, so do something like just download an Artifacts.toml file from a JLL and embed it directly into the test suite here.

DilumAluthge commented 4 months ago

@gbaraldi What's the status here? We just need to fix the fooifier problem?

DilumAluthge commented 5 days ago

Bump @gbaraldi @staticfloat

What needs to be done to fix CI here?