Fix bug in create_sysimg_from_object_file for Xcode 15 CLT

jayscook commented 6 months ago

Fix for issue #738, which conditionally adds the -Wl,-ld_classic flags to o_file_flags in create_sysimg_from_object_file based on Xcode CLT version.

All credit to @PhilReinhold for this code; I'm simply opening this PR based on his latest correspondence on the issue.

Tested locally on gcc 15.0.0 and Julia 1.8.5. @hbe72 confirmed in the issue correspondence that it's working on gcc 15.0.0 and Julia 1.10

Re: CI failures, I'm seeing other recent PRs (1, 2) that are also failing the nightly build tests and buildkite. Please let me know if you see anything in this change that should address these failures.

ufechner7 commented 2 months ago

Can this be merged?

jayscook commented 2 months ago

Can this be merged?

This comment feels like one that should be addressed, but I don't have the know-how to devise a solution. Hopefully @topolarity can suggest a solution.

The other option would be to merge as-is as a step forward and address the above issue when it becomes an issue for someone.

ufechner7 commented 2 months ago

Well, the macOS tests still fail. But with a different (?) error:

 ERROR: LoadError: Cannot locate artifact 'fooifier' for aarch64-apple-darwin-libgfortran5-cxx11-julia_version+1.10.4 in '/private/var/folders/zn/hj183dg15s713b47j2wlhwzw0000gn/T/jl_7YRmdg/MyApp/Artifacts.toml'

I mean, this is easy to fix:

Unfortunately, Julia 1.6 and 1.7 do not have native binaries available for Apple Silicon macOS.
Therefore, it is not possible to install Julia with the current constraints.
For instructions on how to fix this error, please see the following Discourse post: https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019

But it also fails on Julia 1.10.

JuliaLang / PackageCompiler.jl

Fix bug in create_sysimg_from_object_file for Xcode 15 CLT #935