search

JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.39k stars 185 forks source link

Make implicit function definition (in `julia_init.c`) an error #936

Closed topolarity closed 3 months ago

topolarity commented 3 months ago

Someone more familiar with Julia than with C is not likely to recognize the significance of this error, but it's almost always a sign that you've built an object with a broken ABI somewhere.

I've also almost never seen this intentionally ignored in the wild, so I don't expect many false positives.

topolarity commented 3 months ago

fwiw, @gbaraldi would like to compile with -Wall -Werror

I do like that hygiene, but it might need a flag since it's not uncommon to get warnings due to headers somewhat outside your control.

sjkelly commented 3 months ago

fwiw, @gbaraldi would like to compile with -Wall -Werror

I think -Wall would be helpful.

topolarity commented 3 months ago

Yeah, I agree - but let's tackle that in a separate PR to collect more input 👍