search

JuliaLang / PackageCompiler.jl

Compile your Julia Package
https://julialang.github.io/PackageCompiler.jl/dev/
MIT License
1.41k stars 189 forks source link

Make Julia 1.11 work, fix #951 #954

Open ufechner7 opened 1 month ago

ufechner7 commented 1 month ago

Implement suggestion from #951

ufechner7 commented 1 month ago

The tests for macOS still fail for reasons that I do not understand. Could some have a look at the error messages who knows macOS better than me?

PatrickHaecker commented 1 month ago

Thanks for doing the PR!

I am a bit puzzled: To my understanding the code change in embedding_wrapper.c should not have any influence on Julia <= 1.10. Has it really worked before your PR or is the CI failing on macOS a different issue independent of the 1.11 change?

ufechner7 commented 1 month ago

CI fails since May 2023, since this commit: https://github.com/JuliaLang/PackageCompiler.jl/commit/33428b2d9c9daf71bbc478a18385358e1b61a137 Would still be nice to understand and fix the CI failures.

PatrickHaecker commented 1 month ago

Yes, that would be nice. But I suggest that we track that in a different topic.

`$(get_julia_cmd()) --sysimage=$sysimage -e 'using Pkg; Pkg.precompile()'`

probably has a non-zero return value when run, but without access to a macOS Julia installation that is indeed hard to impossible to debug.

ufechner7 commented 1 month ago

I created a separate issue for the CI failures on Mac: #955