JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
620 stars 260 forks source link

compiled-modules flag handling is wrong #3669

Closed vtjnash closed 11 months ago

vtjnash commented 11 months ago

I don't know why it is trying to override the Base.julia_cmd value here...with the same value. But it mean Pkg fails for --compiled-modules=existing

(@v1.8) pkg> add SparseIR
   Resolving package versions...
ERROR: InexactError: Bool(2)
Stacktrace:
  [1] Bool
    @ Base ./float.jl:233 [inlined]
  [2] gen_build_code(build_file::String; inherit_project::Bool)
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1030
  [3] gen_build_code
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1024 [inlined]
  [4] collect_artifacts(pkg_root::String; platform::Base.BinaryPlatforms.Platform)
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:716
  [5] collect_artifacts
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:703 [inlined]
  [6] download_artifacts(env::Pkg.Types.EnvCache; platform::Base.BinaryPlatforms.Platform, julia_version::VersionNumber, verbose::Bool, io::Pkg.UnstableIO)
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:749
  [7] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}, new_git::Set{Base.UUID}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform)
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1394
  [8] add
    @ Pkg.Operations ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1376 [inlined]
  [9] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, kwargs::@Kwargs{io::Pkg.UnstableIO})
    @ Pkg.API ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:278
 [10] add(pkgs::Vector{Pkg.Types.PackageSpec}; io::Pkg.UnstableIO, kwargs::@Kwargs{})
    @ Pkg.API ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:159
 [11] add(pkgs::Vector{Pkg.Types.PackageSpec})
    @ Pkg.API ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:148
 [12] do_cmd!(command::Pkg.REPLMode.Command, repl::REPL.LineEditREPL)
    @ Pkg.REPLMode ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/REPLMode/REPLMode.jl:412
 [13] do_cmd(repl::REPL.LineEditREPL, input::String; do_rethrow::Bool)
    @ Pkg.REPLMode ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/REPLMode/REPLMode.jl:390
 [14] do_cmd
    @ ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/REPLMode/REPLMode.jl:380 [inlined]
 [15] (::Pkg.REPLMode.var"#24#27"{REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
    @ Pkg.REPLMode ~/julia/usr/share/julia/stdlib/v1.11/Pkg/src/REPLMode/REPLMode.jl:557
 [16] #invokelatest#2
    @ Base ./essentials.jl:929 [inlined]
 [17] invokelatest
    @ Base ./essentials.jl:926 [inlined]
 [18] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
    @ REPL.LineEdit ~/julia/usr/share/julia/stdlib/v1.11/REPL/src/LineEdit.jl:2714
 [19] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
    @ REPL ~/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:1352
 [20] (::REPL.var"#64#70"{REPL.LineEditREPL, REPL.REPLBackendRef})()
    @ REPL ~/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:401
vchuravy commented 11 months ago

I assume it's historic and that the flag didn't used to be propagated.