Closed mkitti closed 4 months ago
Looks like this has to be rebased to update for another use of UnstableIO
(looking at the CI):
┌ Pkg
│ WARNING: could not import Pkg.UnstableIO into Operations
└
Testing Running tests...
ERROR: LoadError: UndefVarError: `UnstableIO` not defined in `Pkg.Operations`
Stacktrace:
[1] subprocess_handler(cmd::Cmd, io::IOContext{IO}, error_msg::String)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:2223
[2] (::Pkg.Operations.var"#138#143"{Pkg.Types.Context})()
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:2129
I will take a look, thanks.
@KristofferC CI is now passing here.
👍
While trying to send UnstableIO into Julia base, two suggestions arose:
Base.inferencebarrier
to prevent specialization: https://github.com/JuliaLang/julia/pull/52249#discussion_r1401199265IOContext{IO}
rather than introducing a new type: https://github.com/JuliaLang/julia/pull/52249#discussion_r1425332525Fix #3722 (
IOContext
hasclosewrite
) Addresses part of #3702 by removingUnstableIO
and its associated invalidations.