search

JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
613 stars 251 forks source link

Use `Base.format_bytes` #3763

Closed christiangnrd closed 2 months ago

christiangnrd commented 6 months ago

Reduces code duplication and fixes lack of pluralization when trying to pretty print 2-1024 bytes.

Closes https://github.com/JuliaLang/Pkg.jl/pull/3799.

christiangnrd commented 3 months ago

Bump. I've made a sample output to show what this changes. Note that integer numbers of bytes don't have trailing 0s unlike in #3799.

Before:

Deleted `0byte.txt` (0.000 byte)
Deleted `1byte.txt` (1.000 byte)
Deleted `2bytes.txt` (2.000 byte)
Deleted `1023bytes.txt` (1023.000 byte)
Deleted `1024bytes.txt` (1024.000 byte)
Deleted `1025bytes.txt` (1.001 KiB)
Deleted 1 package (0.000 byte)
Deleted 1 package (1.000 byte)
Deleted 1 package (2.000 byte)
Deleted 1 package (1023.000 byte)
Deleted 1 package (1024.000 byte)
Deleted 1 package (1.001 KiB)

After:

Deleted `0byte.txt` (0 bytes)
Deleted `1byte.txt` (1 byte)
Deleted `2bytes.txt` (2 bytes)
Deleted `1023bytes.txt` (1023 bytes)
Deleted `1024bytes.txt` (1024 bytes)
Deleted `1025bytes.txt` (1.001 KiB)
Deleted 1 package (0 bytes)
Deleted 1 package (1 byte)
Deleted 1 package (2 bytes)
Deleted 1 package (1023 bytes)
Deleted 1 package (1024 bytes)
Deleted 1 package (1.001 KiB)